Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARD-460 - feat: Make payload size limit a shardus config #15

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

jintukumardas
Copy link

Added the payload size limit to the SnOpts type and updated the Sn function to use the provided limit.

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Error Handling
The error handling for the conversion of JavaScript number to Rust usize (line 420) is marked with a TODO but not implemented. This could lead to potential runtime errors if the conversion fails or is inaccurate.

Error Handling
The error message in line 102 does not provide details about what action to take or more context about the error, which might not be helpful for debugging.

shardus_net/src/lib.rs Show resolved Hide resolved
shardus_net/src/shardus_net_listener.rs Outdated Show resolved Hide resolved
@jintukumardas jintukumardas changed the title feat: Make payload size limit a shardus config [DRAFT] feat: Make payload size limit a shardus config Dec 3, 2024
@jintukumardas jintukumardas changed the title [DRAFT] feat: Make payload size limit a shardus config feat: Make payload size limit a shardus config Dec 4, 2024
@justin-shardeum justin-shardeum changed the title feat: Make payload size limit a shardus config SHARD-460 - feat: Make payload size limit a shardus config Dec 5, 2024
@aniketdivekar aniketdivekar merged commit 023b6dd into dev Dec 9, 2024
7 checks passed
@aniketdivekar aniketdivekar deleted the GOLD-221 branch December 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants